Typescript multisig upgrade#2758
Open
theodorebugnet wants to merge 5 commits intotheodore/multisig-upgradefrom
Open
Typescript multisig upgrade#2758theodorebugnet wants to merge 5 commits intotheodore/multisig-upgradefrom
theodorebugnet wants to merge 5 commits intotheodore/multisig-upgradefrom
Conversation
ross-weir
reviewed
Apr 20, 2026
|
|
||
| export type StandardRollupSpec<RuntimeCall> = { | ||
| UnsignedTransaction: UnsignedTransaction<RuntimeCall>; | ||
| UnsignedTransaction: UnsignedTransactionV0<RuntimeCall>; |
Member
There was a problem hiding this comment.
Should this be UnsignedTransaction?
Contributor
Author
There was a problem hiding this comment.
Nope - the standard rollup lets users feed in an UnsignedTransactionV0 and internally wraps it in the V0: { ... } envelope for serialization by overriding the new unsignedTxForSigning() helper.
The type name is not super ergonomic but see my note on typing in the PR description - this works, but I'll see if I can introduce a separation between "the bytes serialized for signing" and "the payload the user assembles" (which are currently both represented by UnsignedTransaction, leading to awkward naming like this). This also affects the Rust side in the same way, so if I write a fix it'd be applied to both the rust and TS types.
Base automatically changed from
theodore/witnesless-hash
to
theodore/multisig-upgrade
April 21, 2026 10:38
theodorebugnet
force-pushed
the
theodore/typescript-multisig-upgrade
branch
from
93ff6ea to
b1be85f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Typescript SDK according to the new multisig signing format for the upgrade.
UnsignedTransactionis nowUnsignedTransactionV0, with its three basic fields. The newUnsignedTransctiontype is the enum used for serializing for signing, as per the new rust implementation. (See below for some more thoughts on this.)payloadfrom Multisig package, it's now only used to manage and aggregate signatures (similar to the rustMultisigtype)web3now depends onmultisig(and theweb3dependency inmultisigis removed, which was only used for the integration test, which is moved into theintegration-testpackage)Some thoughts on the types: V0 and V1 both share the same basic fields that define a user-created transaction, and which are also included in both Transaction variants. It may or may not be worthwhile to define a special
UnsignedTransactionPayloadtype or similar, with the semantics being that the "payload" is what users construct, then anUnsignedTransactionis the actual signed bytes (in the V0 case that's the payload + chain hash, in V1 that's payload + multisig credential + chain hash). Or keepUnsignedTransactionas the old type and introduceSigningPayload.However, this change should probably be coordinated across both Rust and TS; right now I've kept the TS following my current Rust implementation. If we do rename, the functionality will mostly not change, so I think I'd rather go ahead with this PR and then consider the type ergonomics as a follow-up.
CHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?
Rendered docs are available at
https://sovlabs-ci-rustdoc-artifacts.us-east-1.amazonaws.com/<BRANCH_NAME>/index.html